[
https://issues.apache.org/jira/browse/HDFS-11011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595707#comment-15595707
]
Xiaoyu Yao commented on HDFS-11011:
-----------------------------------
Thanks [~xiaobingo] and [~liuml07] for working on this. The v007 looks good to
me overall. I just have two questions:
1. TestQuota#setUp() is introduced with @Before to start a new cluster instance
for each test and assigned to TestQuota#dfsCluster. However, there are a few
existing test still using separate local DFSMinicluster instance such as
TestQuota#testSpaceCommands, TestQuota#testQuotaByStorageType, etc., can you
fix them to use TestQuota#dfsCluster to avoid unnecessary mini cluster creation?
2. Glad to see new tests are added with dedicated test paths. Can you try to
run the suite with a single MiniCluster instance that is created with
@BeforeClass to save spinup/shutdown cluster for each tests?
{code}
final Path parent = new Path(
PathUtils.getTestPath(getClass()),
GenericTestUtils.getMethodName());
{code}
> Add unit tests for HDFS command 'dfsadmin -set/clrSpaceQuota'
> -------------------------------------------------------------
>
> Key: HDFS-11011
> URL: https://issues.apache.org/jira/browse/HDFS-11011
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Labels: fs, shell, test
> Attachments: HDFS-11011.000.patch, HDFS-11011.001.patch,
> HDFS-11011.002.patch, HDFS-11011.003.patch, HDFS-11011.004.patch,
> HDFS-11011.005.patch, HDFS-11011.006.patch, HDFS-11011.007.patch
>
>
> This proposes adding a bunch of unit tests for command 'dfsadmin
> setSpaceQuota' and 'dfsadmin clrSpaceQuota'.
> 1. test to set space quote using negative number.
> 2. test to set and clear space quote, regular usage.
> 3. test to set and clear space quote by storage type.
> 4. test to set and clear space quote when directory doesn't exist.
> 5. test to set and clear space quote when path is a file.
> 6. test to set and clear space quote when user has no access right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
