[
https://issues.apache.org/jira/browse/HDFS-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597224#comment-15597224
]
Uma Maheswara Rao G commented on HDFS-10884:
--------------------------------------------
[~rakeshr] Thanks. Please check below.
# {quote}
How about renaming the handler class to BlockMovementsCompletionHandler
representing collection of block movements under the respective trackId?
{quote}
you mean BlocksMovementsCompletionHandler? It make sense to me.
# -
{code}
+ // TODO: Need to revisit this when NN is implemented to be able to send
+ // block moving commands.
{code}
Can you check this TODO? Now protobuf with commands done right?
# TestStoragePolicySatisfyWorker.java: It would be good if we cover to add some
test cases to get end result per trackID with some special conditions, like
when no space on one target but other block targets are fine, then result
should be retry. etc. When target node completely down etc. I am ok if you
planned this in another patch, but have a plan to cover.
Once addressed this, we can push this important patch. Thanks
> [SPS]: Add block movement tracker to track the completion of block movement
> future tasks at DN
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-10884
> URL: https://issues.apache.org/jira/browse/HDFS-10884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: HDFS-10285
> Reporter: Rakesh R
> Assignee: Rakesh R
> Attachments: HDFS-10884-HDFS-10285-00.patch,
> HDFS-10884-HDFS-10285-01.patch, HDFS-10884-HDFS-10285-02.patch,
> HDFS-10884-HDFS-10285-03.patch, HDFS-10884-HDFS-10285-04.patch
>
>
> Presently
> [StoragePolicySatisfyWorker#processBlockMovingTasks()|https://github.com/apache/hadoop/blob/HDFS-10285/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/StoragePolicySatisfyWorker.java#L147]
> function act as a blocking call. The idea of this jira is to implement a
> mechanism to track these movements async so that would allow other movement
> while processing the previous one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
