[ https://issues.apache.org/jira/browse/HDFS-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617863#comment-15617863 ]
Hadoop QA commented on HDFS-9337: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 2 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 51s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 26s{color} | {color:orange} hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 204 unchanged - 0 fixed = 210 total (was 204) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 47s{color} | {color:red} hadoop-hdfs-project/hadoop-hdfs generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 68m 21s{color} | {color:green} hadoop-hdfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 86m 43s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-hdfs-project/hadoop-hdfs | | | Null pointer dereference of xattrNames in org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods.get(UserGroupInformation, DelegationParam, UserParam, DoAsParam, String, GetOpParam, OffsetParam, LengthParam, RenewerParam, BufferSizeParam, List, XAttrEncodingParam, ExcludeDatanodesParam, FsActionParam, TokenKindParam, TokenServiceParam, NoRedirectParam, StartAfterParam) Dereferenced at NamenodeWebHdfsMethods.java:in org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods.get(UserGroupInformation, DelegationParam, UserParam, DoAsParam, String, GetOpParam, OffsetParam, LengthParam, RenewerParam, BufferSizeParam, List, XAttrEncodingParam, ExcludeDatanodesParam, FsActionParam, TokenKindParam, TokenServiceParam, NoRedirectParam, StartAfterParam) Dereferenced at NamenodeWebHdfsMethods.java:[line 1059] | | | Load of known null value in org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods.get(UserGroupInformation, DelegationParam, UserParam, DoAsParam, String, GetOpParam, OffsetParam, LengthParam, RenewerParam, BufferSizeParam, List, XAttrEncodingParam, ExcludeDatanodesParam, FsActionParam, TokenKindParam, TokenServiceParam, NoRedirectParam, StartAfterParam) At NamenodeWebHdfsMethods.java:in org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods.get(UserGroupInformation, DelegationParam, UserParam, DoAsParam, String, GetOpParam, OffsetParam, LengthParam, RenewerParam, BufferSizeParam, List, XAttrEncodingParam, ExcludeDatanodesParam, FsActionParam, TokenKindParam, TokenServiceParam, NoRedirectParam, StartAfterParam) At NamenodeWebHdfsMethods.java:[line 1059] | | | Redundant nullcheck of xattrNames, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods.get(UserGroupInformation, DelegationParam, UserParam, DoAsParam, String, GetOpParam, OffsetParam, LengthParam, RenewerParam, BufferSizeParam, List, XAttrEncodingParam, ExcludeDatanodesParam, FsActionParam, TokenKindParam, TokenServiceParam, NoRedirectParam, StartAfterParam) Redundant null check at NamenodeWebHdfsMethods.java:is known to be non-null in org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods.get(UserGroupInformation, DelegationParam, UserParam, DoAsParam, String, GetOpParam, OffsetParam, LengthParam, RenewerParam, BufferSizeParam, List, XAttrEncodingParam, ExcludeDatanodesParam, FsActionParam, TokenKindParam, TokenServiceParam, NoRedirectParam, StartAfterParam) Redundant null check at NamenodeWebHdfsMethods.java:[line 1063] | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | HDFS-9337 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12835961/HDFS-9337_10.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux f29ffb77b28c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 1c8ab41 | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/17347/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt | | findbugs | https://builds.apache.org/job/PreCommit-HDFS-Build/17347/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17347/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17347/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Should check required params in WebHDFS to avoid NPE > ---------------------------------------------------- > > Key: HDFS-9337 > URL: https://issues.apache.org/jira/browse/HDFS-9337 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Jagadesh Kiran N > Assignee: Jagadesh Kiran N > Attachments: HDFS-9337_00.patch, HDFS-9337_01.patch, > HDFS-9337_02.patch, HDFS-9337_03.patch, HDFS-9337_04.patch, > HDFS-9337_05.patch, HDFS-9337_06.patch, HDFS-9337_07.patch, > HDFS-9337_08.patch, HDFS-9337_09.patch, HDFS-9337_10.patch > > > {code} > curl -i -X PUT > "http://10.19.92.127:50070/webhdfs/v1/kiran/sreenu?op=RENAMESNAPSHOT&snapshotname=SNAPSHOTNAME" > {code} > Null point exception will be thrown > {code} > {"RemoteException":{"exception":"NullPointerException","javaClassName":"java.lang.NullPointerException","message":null}} > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org