[
https://issues.apache.org/jira/browse/HDFS-11115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648021#comment-15648021
]
Kihwal Lee commented on HDFS-11115:
-----------------------------------
You are undoing this optimization.
{code}
// Using the charset canonical name for String/byte[] conversions is much
// more efficient due to use of cached encoders/decoders.
private static final String UTF8_CSN = StandardCharsets.UTF_8.name();
{code}
> Remove bytes2Array and string2Bytes
> -----------------------------------
>
> Key: HDFS-11115
> URL: https://issues.apache.org/jira/browse/HDFS-11115
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs, hdfs-client
> Reporter: Sahil Kang
> Priority: Minor
>
> In DFSUtilClient.java we have something like:
> {code: language=java}
> public static byte[] string2Bytes(String str) {
> try {
> return str.getBytes("UTF-8");
> } catch (UnsupportedEncodingException e) {
> throw new IllegalArgumentException("UTF8 decoding is not supported", e);
> }
> }
> static String bytes2String(byte[] bytes, int offset, int length) {
> try {
> return new String(bytes, offset, length, "UTF-8");
> } catch (UnsupportedEncodingException e) {
> throw new IllegalArgumentException("UTF8 encoding is not supported", e);
> }
> }
> {code}
> Using StandardCharsets, these methods become trivial:
> {code: language=java}
> public static byte[] string2Bytes(String str) {
> return str.getBytes(StandardCharsets.UTF_8);
> }
> static String bytes2String(byte[] bytes, int offset, int length) {
> return new String(bytes, offset, length, StandardCharsets.UTF_8);
> }
> {code}
> I think we should remove these methods and use StandardCharsets whenever we
> need to convert between bytes and strings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
