[ https://issues.apache.org/jira/browse/HDFS-11122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652671#comment-15652671 ]
Yiqun Lin edited comment on HDFS-11122 at 11/10/16 1:49 AM: ------------------------------------------------------------ Thanks [~tasanuma0829] for sharing the thought. {quote} MiniDFSCluster#corruptBlockOnDataNodes does not assure that the datanodes recognize the corrupt block. {quote} This line {{assertEquals("Fail to corrupt all replicas for block " + block, replFactor, blockFilesCorrupted);}} can't assure the corrupt block has been recognized in test(Correct me if I am wrong). In addition, your proposal looks good. was (Author: linyiqun): Thanks [~tasanuma0829] for sharing the thought. {quote} MiniDFSCluster#corruptBlockOnDataNodes does not assure that the datanodes recognize the corrupt block. {quote} This line {{assertEquals("Fail to corrupt all replicas for block " + block, replFactor, blockFilesCorrupted);}} can't assure the corrupt block has been recognized in test, Correct me if I am wrong. Thanks! > TestDFSAdmin.testReportCommand fails due to timed out > ----------------------------------------------------- > > Key: HDFS-11122 > URL: https://issues.apache.org/jira/browse/HDFS-11122 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: 3.0.0-alpha1 > Reporter: Yiqun Lin > Assignee: Yiqun Lin > Priority: Minor > Attachments: HDFS-11122.001.patch, HDFS-11122.002.patch > > > After HDFS-11083, the test {{TestDFSAdmi}} fails sometimes dueto timed out. > The stack > infos(https://builds.apache.org/job/PreCommit-HDFS-Build/17484/testReport/): > {code} > java.lang.Exception: test timed out after 30000 milliseconds > at java.lang.Thread.sleep(Native Method) > at > org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:268) > at > org.apache.hadoop.hdfs.tools.TestDFSAdmin.testReportCommand(TestDFSAdmin.java:540) > {code} > The timed out is happened in {{GenericTestUtils.waitFor}}. We can make a > improvement in the logic of waiting the corrupt blocks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org