[ https://issues.apache.org/jira/browse/HDFS-10872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654931#comment-15654931 ]
Erik Krogen commented on HDFS-10872: ------------------------------------ [~zhz], thanks for the review. (1) Yes, you are right, that is unnecessary. (2) Fixed. I'm surprised my IDE didn't warn me of this. (3) Agreed that this could be a good follow-up, there is a lot of duplicated logic. Could be good to do something to consolidate with HADOOP-13702 as well. Attaching v007 patch. > Add MutableRate metrics for FSNamesystemLock operations > ------------------------------------------------------- > > Key: HDFS-10872 > URL: https://issues.apache.org/jira/browse/HDFS-10872 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Erik Krogen > Assignee: Erik Krogen > Attachments: FSLockPerf.java, HDFS-10872.000.patch, > HDFS-10872.001.patch, HDFS-10872.002.patch, HDFS-10872.003.patch, > HDFS-10872.004.patch, HDFS-10872.005.patch, HDFS-10872.006.patch > > > Add metrics for FSNamesystemLock operations to see, overall, how long each > operation is holding the lock for. Use MutableRate metrics for now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org