[ 
https://issues.apache.org/jira/browse/HDFS-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15671281#comment-15671281
 ] 

Chen Liang commented on HDFS-11138:
-----------------------------------

Thanks [~anu] for the comments!

Here were my thoughts on some of the comments, and will address the rest and 
submit another patch:
(#5)
bq. Slightly confused about how we use this, We have RPCs which take 
forceDelete as a parameter, we also have forceDelete as a config key. I am 
trying to decide which one takes precedence and why we need both.
The idea is that the force flag is only an optional flag, i.e. the call may not 
have this flag. In which case a default value will be used. This key is to 
allow users specify different default behavior when force flag is missing. This 
being said, user parameter, if given, takes precedence.

(#11)
bq. VolumeDescriptor.java I am not able to understand why we have to maintain 
this map. Can you please explain the use case ?  private HashMap<String, 
ContainerDescriptor> containerMap;
This is where server side maintains the containers of a volume. Say, when users 
request infoContainers, this is where server gets all containers and iterate on 
them. The ideal here was that, in addition to just an id of a container, server 
also maintains some information about each container, including a handler to 
allow communication to the container on info request, and other information to 
keep in persistent storage and failover, all this wrapped in 
ContainerDescriptor.

> Block Storage : add block storage server
> ----------------------------------------
>
>                 Key: HDFS-11138
>                 URL: https://issues.apache.org/jira/browse/HDFS-11138
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-11138-HDFS-7240.001.patch
>
>
> This JIRA adds the skeleton for server side code, which is one of the core 
> components in block storage. For performance concerns, the server does not 
> handle any actual read/write operation but serving primarily as a meta data 
> server. It provides four APIs:
> # create volume : which will call into underlying container layer to allocate 
> containers
> # delete volume : delete a specific volume (as well as its containers)
> # info volume : return information of a specific volume
> # list volume : list all volumes
> Note that this is still subject to potentially major changes. Features such 
> as persistence are missing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to