[ 
https://issues.apache.org/jira/browse/HDFS-11148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15672025#comment-15672025
 ] 

ASF GitHub Bot commented on HDFS-11148:
---------------------------------------

Github user anuengineer commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/162#discussion_r88354002
  
    --- Diff: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
 ---
    @@ -1935,6 +1937,10 @@ public void shutdown() {
           }
         }
     
    +    if (storageLocationChecker != null) {
    +      storageLocationChecker.shutdownAndWait(10, TimeUnit.SECONDS);
    --- End diff --
    
    Something for you to consider, most of the other threads seems to shutdown 
much quicker, do we need to wait 10 seconds ? 


> Update DataNode to use StorageLocationChecker at startup
> --------------------------------------------------------
>
>                 Key: HDFS-11148
>                 URL: https://issues.apache.org/jira/browse/HDFS-11148
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>
> The DataNode can use the {{StorageLocationChecker}} introduced by HDFS-11119 
> to parallelize checking Storage Locations at process startup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to