[
https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688196#comment-15688196
]
Arpit Agarwal commented on HDFS-10930:
--------------------------------------
The findbugs issue looks valid. It can be addressed by restoring the close
calls in the {{finally}} block if the {{ris}} is null.
{code}
} finally {
if (ris != null) {
ris.close();
+ } else {
+ IOUtils.closeStream(checksumIn);
+ IOUtils.closeStream(blockIn);
}
{code}
The function will need some more changes to restore scoping for checksumIn and
blockIn.
> Refactor: Wrap Datanode IO related operations
> ---------------------------------------------
>
> Key: HDFS-10930
> URL: https://issues.apache.org/jira/browse/HDFS-10930
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-10930.01.patch, HDFS-10930.02.patch,
> HDFS-10930.03.patch, HDFS-10930.04.patch, HDFS-10930.05.patch,
> HDFS-10930.06.patch
>
>
> Datanode IO (Disk/Network) related operations and instrumentations are
> currently spilled in many classes such as DataNode.java, BlockReceiver.java,
> BlockSender.java, FsDatasetImpl.java, FsVolumeImpl.java,
> DirectoryScanner.java, BlockScanner.java, FsDatasetAsyncDiskService.java,
> LocalReplica.java, LocalReplicaPipeline.java, Storage.java, etc.
> This ticket is opened to consolidate IO related operations for easy
> instrumentation, metrics collection, logging and trouble shooting.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
