[ https://issues.apache.org/jira/browse/HDFS-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710712#comment-15710712 ]
Brahma Reddy Battula edited comment on HDFS-10930 at 12/1/16 3:22 AM: ---------------------------------------------------------------------- *Regarding Trunk commit.* 1) Seems mistakenly given jiraID,should be HDFS-10930..? {noformat}HADOOP-10930. Refactor: Wrap Datanode IO related operations. Contributed by Xiaoyu Yao.{noformat} 2) can you look following findbug? {noformat} FindBugs : module:hadoop-hdfs-project/hadoop-hdfs org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.BlockPoolSlice.validateIntegrityAndSetLength(File, long) may fail to clean up java.io.InputStream on checked exception Obligation to clean up resource created at BlockPoolSlice.java:clean up java.io.InputStream on checked exception Obligation to clean up resource created at BlockPoolSlice.java:[line 720] is not discharged {noformat} was (Author: brahmareddy): *Regarding Trunk commit.* 1) Seems commit message contains wrong jiraID,it should be HDFS-10930 {noformat}HADOOP-10930. Refactor: Wrap Datanode IO related operations. Contributed by Xiaoyu Yao.{noformat} 2) can you look following findbug? {noformat} FindBugs : module:hadoop-hdfs-project/hadoop-hdfs org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.BlockPoolSlice.validateIntegrityAndSetLength(File, long) may fail to clean up java.io.InputStream on checked exception Obligation to clean up resource created at BlockPoolSlice.java:clean up java.io.InputStream on checked exception Obligation to clean up resource created at BlockPoolSlice.java:[line 720] is not discharged {noformat} > Refactor: Wrap Datanode IO related operations > --------------------------------------------- > > Key: HDFS-10930 > URL: https://issues.apache.org/jira/browse/HDFS-10930 > Project: Hadoop HDFS > Issue Type: Improvement > Components: datanode > Reporter: Xiaoyu Yao > Assignee: Xiaoyu Yao > Fix For: 3.0.0-alpha2 > > Attachments: HDFS-10930-branch-2.00.patch, > HDFS-10930-branch-2.001.patch, HDFS-10930.01.patch, HDFS-10930.02.patch, > HDFS-10930.03.patch, HDFS-10930.04.patch, HDFS-10930.05.patch, > HDFS-10930.06.patch, HDFS-10930.07.patch, HDFS-10930.barnch-2.00.patch > > > Datanode IO (Disk/Network) related operations and instrumentations are > currently spilled in many classes such as DataNode.java, BlockReceiver.java, > BlockSender.java, FsDatasetImpl.java, FsVolumeImpl.java, > DirectoryScanner.java, BlockScanner.java, FsDatasetAsyncDiskService.java, > LocalReplica.java, LocalReplicaPipeline.java, Storage.java, etc. > This ticket is opened to consolidate IO related operations for easy > instrumentation, metrics collection, logging and trouble shooting. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org