[
https://issues.apache.org/jira/browse/HDFS-11207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15723622#comment-15723622
]
Eric Badger edited comment on HDFS-11207 at 12/5/16 10:54 PM:
--------------------------------------------------------------
It looks like {{HAServiceState}} is used in more places than just
DatanodeProtocolProtos. Because of that, we can't simply change
{{HAServiceState}} or else we will have the exact same problem that we're
trying to fix. Moral of the story, we need 2 enums that will define {{ACTIVE}}
and {{STANDBY}} differently. Cancelling the patch
was (Author: ebadger):
It looks like {{HAServiceState}} is used in more places than just
DatanodeProtocolProtos. Because of that, we can't simply change
{{HAServiceState}} or else we will have the exact same problem that we're
trying to fix. Moral of the story, we need 2 enums that will define {{ACTIVE}}
and {{STANDBY}} differently.
> Unnecessary incompatible change of NNHAStatusHeartbeat.state in
> DatanodeProtocolProtos
> --------------------------------------------------------------------------------------
>
> Key: HDFS-11207
> URL: https://issues.apache.org/jira/browse/HDFS-11207
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Eric Badger
> Assignee: Eric Badger
> Attachments: HDFS-11207.001.patch
>
>
> HDFS-5079 changed the meaning of state in {{NNHAStatusHeartbeat}} when it
> added in the {{INITIALIZING}} state via {{HAServiceStateProto}}.
> Before change:
> {noformat}
> enum State {
> ACTIVE = 0;
> STANDBY = 1;
> }
> {noformat}
> After change:
> {noformat}
> enum HAServiceStateProto {
> INITIALIZING = 0;
> ACTIVE = 1;
> STANDBY = 2;
> }
> {noformat}
> So the new {{INITIALIZING}} state will be interpreted as {{ACTIVE}}, new
> {{ACTIVE}} interpreted as {{STANDBY}} and new {{STANDBY}} interpreted as
> unknown. Any rolling upgrade to 3.0.0 will break because the datanodes that
> haven't been updated will misinterpret the NN state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
