[ 
https://issues.apache.org/jira/browse/HDFS-11224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731649#comment-15731649
 ] 

Brahma Reddy Battula commented on HDFS-11224:
---------------------------------------------

[~vinayrpet] Nice Catch...

Patch LGTM, apart from following minor nit.

can we update the following comment also..?

{code}
      // This is null if the DataNode has not yet registered.  We expect this
      // will never happen, because the DataNode has logic to prevent sending
      // lifeline messages until after initial registration is successful.
      // Lifeline message handling can't send commands back to the DataNode to
      // tell it to register, so simply exit.
{code}

> Lifeline message should be ignored for dead nodes
> -------------------------------------------------
>
>                 Key: HDFS-11224
>                 URL: https://issues.apache.org/jira/browse/HDFS-11224
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>            Priority: Critical
>         Attachments: HDFS-11224-01.patch
>
>
> Lifeline messages should be ignored for dead nodes in NameNode.
> Otherwise, cluster level stats such as capacity, used, etc will be doubled, 
> after re-registration of node.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to