[
https://issues.apache.org/jira/browse/HDFS-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770866#comment-15770866
]
Mingliang Liu commented on HDFS-11270:
--------------------------------------
Thanks [~linyiqun]. I think the patch is good overall.
One minor comment is about
{quote}
-skipSharedEditsCheck option skips edits check, the edits check can ensure we
have enough edits already in the shared directory to start up, otherwise it
will aborts the download of fsimage file from active namenode.
{quote}
It'd be better to have two sentences as "otherwise" case is not very
straightforward. And perhaps we don't have to mention the implementation detail
of downloading fsimage from active namenode; it also skips the possible
upgrade. How about:
{quote}
-skipSharedEditsCheck option skips edits check which ensures that we have
enough edits already in the shared directory to start up from the last
checkpoint on the active.
{quote}
> Document the missing options of NameNode bootstrap command
> ----------------------------------------------------------
>
> Key: HDFS-11270
> URL: https://issues.apache.org/jira/browse/HDFS-11270
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
> Affects Versions: 3.0.0-alpha2
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Priority: Minor
> Attachments: HDFS-11270.001.patch
>
>
> Currently there are missing three options introduction in {{HDFSCommands.md}}
> of command {{hdfs namenode [-bootstrapStandby]}}. Now this command can
> support {{-force}}, {{-nonInteractive}} and a additional option
> {{-skipSharedEditsCheck}}. It will be better to document what's the meaning
> of these options and that will let users know how to use it correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
