[ 
https://issues.apache.org/jira/browse/HDFS-11186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15781804#comment-15781804
 ] 

Rakesh R edited comment on HDFS-11186 at 12/28/16 2:14 AM:
-----------------------------------------------------------

Thanks [~zhouwei] for the updates. Overall the patch looks good to me. Could 
you clarify on the below test changes in your patch,

{{TestHAStateTransitions.java}}, {{TestSeveralNameNodes.java}} - any specific 
reason to increase to a high value?




was (Author: rakeshr):
Thanks [~zhouwei] for the updates. Overall the patch looks good to me. Could 
you clarify on the below test changes in your patch,
- {{TestHAStateTransitions.java}}, {{TestSeveralNameNodes.java}} - any specific 
reason to increase to a high value?
- {{TestStoragePolicySatisfierWithHA}}- can we keep @Test(timeout = 30000) for 
TestStoragePolicySatisfierWithHA#testWhenNNHAStateChanges?


> [SPS]: Daemon thread of SPS should start only in Active NN
> ----------------------------------------------------------
>
>                 Key: HDFS-11186
>                 URL: https://issues.apache.org/jira/browse/HDFS-11186
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>         Attachments: HDFS-11186-HDFS-10285.00.patch, 
> HDFS-11186-HDFS-10285.01.patch, HDFS-11186-HDFS-10285.02.patch
>
>
> As discussed in [HDFS-10885 
> |https://issues.apache.org/jira/browse/HDFS-10885], we need to ensure that 
> SPS is started only in Active NN. This JIRA is opened for discussion and 
> tracking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to