[
https://issues.apache.org/jira/browse/HDFS-11279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796224#comment-15796224
]
Mingliang Liu commented on HDFS-11279:
--------------------------------------
{{import java.io.File;}} in DataNode seems unnecessary? It will be good if we
keep the javadoc for public test helper method {{getVolume()}}. Other than that
it looks good to me.
> Cleanup unused DataNode#checkDiskErrorAsync()
> ---------------------------------------------
>
> Key: HDFS-11279
> URL: https://issues.apache.org/jira/browse/HDFS-11279
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Xiaoyu Yao
> Assignee: Hanisha Koneru
> Priority: Minor
> Attachments: HDFS-11279.000.patch, HDFS-11279.001.patch
>
>
> After HDFS-11274, we will not trigger checking all datanode volumes upon IO
> failure on a single volume. This makes the original implementation
> DataNode#checkDiskErrorAsync and DatasetVolumeChecker#checkAllVolumesAsync()
> not used in any of the production code.
> This ticket is opened to remove these unused code and related tests if any.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
