[
https://issues.apache.org/jira/browse/HDFS-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799712#comment-15799712
]
Andrew Wang commented on HDFS-11072:
------------------------------------
Thanks for the rev Sammi, looks like we're getting close. Agree that we can
focus on getting this in, and worry about the replication policy later.
Some code review comments:
* nit: can combine these two lines into one in FSDirErasureCodingOp:
{code}
FSPermissionChecker pc = null;
pc = fsn.getPermissionChecker();
{code}
* removeErasureCodingPolicyXAttr can be private
* IOException text says "Attempt to unset an erasure coding policy from a
file", prefer if we be more explicit about the error and say "Cannot unset the
erasure coding policy on a file".
* Why do we need the new {{getLastCompleteINode}} method? IIUC an IIP has nulls
if that path component doesn't exist, but that only happens when we're creating
a new inode. Maybe we should test calling these APIs on a path that does not
exist.
* In TestErasureCodingPolicies, should say "policies are supported" rather than
"policies is supported" in both places
* Additional unit test ideas: setting and unsetting on a file, unsetting when
not set, setting twice on the same directory with different policies
> Add ability to unset and change directory EC policy
> ---------------------------------------------------
>
> Key: HDFS-11072
> URL: https://issues.apache.org/jira/browse/HDFS-11072
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: erasure-coding
> Affects Versions: 3.0.0-alpha1
> Reporter: Andrew Wang
> Assignee: SammiChen
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-11072-v1.patch, HDFS-11072-v2.patch,
> HDFS-11072-v3.patch, HDFS-11072-v4.patch, HDFS-11072-v5.patch
>
>
> Since the directory-level EC policy simply applies to files at create time,
> it makes sense to make it more similar to storage policies and allow changing
> and unsetting the policy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
