[ 
https://issues.apache.org/jira/browse/HDFS-11182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arpit Agarwal updated HDFS-11182:
---------------------------------
    Attachment: HDFS-11182-branch-2.01.patch

Attached a patch for branch-2. [~xyao], can you please take a look at the 
patch. The main difference from trunk is that in branch-2 DatasetVolumeChecker 
returns Set<FsVolumeSpi> whereas in trunk it returns Set<StorageLocation>. 

The difference is that due to branch divergence, we cannot get the 
StorageLocation from an FsVolumeSpi trivially in branch-2. I ran test-patch 
locally and results are below. Also tested the branch-2 patch by simulating 
disk failure and verifying that the failure was caught and the volume was 
removed.

| Vote |      Subsystem |  Runtime   | Comment
============================================================================
|  +1  |       @author  |  0m 0s     | The patch does not contain any @author
|      |                |            | tags.
|  +1  |    test4tests  |  0m 0s     | The patch appears to include 20 new or
|      |                |            | modified test files.
|  +1  |    mvninstall  |  3m 31s    | branch-2 passed
|  +1  |       compile  |  0m 26s    | branch-2 passed
|  +1  |    checkstyle  |  0m 29s    | branch-2 passed
|  +1  |       mvnsite  |  0m 31s    | branch-2 passed
|  +1  |    mvneclipse  |  0m 11s    | branch-2 passed
|  +1  |      findbugs  |  0m 59s    | branch-2 passed
|  +1  |       javadoc  |  0m 38s    | branch-2 passed
|  +1  |    mvninstall  |  0m 26s    | the patch passed
|  +1  |       compile  |  0m 23s    | the patch passed
|  +1  |         javac  |  0m 23s    | the patch passed
|  -1  |    checkstyle  |  0m 26s    | hadoop-hdfs-project/hadoop-hdfs: The
|      |                |            | patch generated 17 new + 994 unchanged -
|      |                |            | 23 fixed = 1011 total (was 1017)
|  +1  |       mvnsite  |  0m 29s    | the patch passed
|  +1  |    mvneclipse  |  0m 8s     | the patch passed
|  +1  |    whitespace  |  0m 0s     | The patch has no whitespace issues.
|  +1  |           xml  |  0m 1s     | The patch has no ill-formed XML file.
|  +1  |      findbugs  |  1m 2s     | the patch passed
|  +1  |       javadoc  |  0m 36s    | the patch passed
|  +1  |          unit  |  201m 0s   | hadoop-hdfs in the patch passed.
|  +1  |    asflicense  |  0m 12s    | The patch does not generate ASF License
|      |                |            | warnings.
|      |                |  212m 21s  |

> Update DataNode to use DatasetVolumeChecker
> -------------------------------------------
>
>                 Key: HDFS-11182
>                 URL: https://issues.apache.org/jira/browse/HDFS-11182
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>             Fix For: 3.0.0-alpha2
>
>         Attachments: HDFS-11182-branch-2.01.patch
>
>
> Update DataNode to use the DatasetVolumeChecker class introduced in 
> HDFS-11149 to parallelize disk checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to