[
https://issues.apache.org/jira/browse/HDFS-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825893#comment-15825893
]
Surendra Singh Lilhore commented on HDFS-11291:
-----------------------------------------------
Thanks [~vinayrpet] for review..
bq. for setReplication() following check can be added directly inside
unprotectedSetReplication() and avoid other changes related to this.
If we add this check in unprotectedSetReplication() then
FSNamesystem.setReplication(..) will return false and I think this is wrong..
I feel, we should return true even old and new replication is same...
> Avoid unnecessary edit log for setStoragePolicy() and setReplication()
> ----------------------------------------------------------------------
>
> Key: HDFS-11291
> URL: https://issues.apache.org/jira/browse/HDFS-11291
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-11291.001.patch, HDFS-11291.002.patch
>
>
> We are setting the storage policy for file without checking the current
> policy of file for avoiding extra getStoragePolicy() rpc call. Currently
> namenode is not checking the current storage policy before setting new one
> and adding edit logs. I think if the old and new storage policy is same we
> can avoid set operation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
