[ https://issues.apache.org/jira/browse/HDFS-11287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manoj Govindassamy updated HDFS-11287: -------------------------------------- Attachment: HDFS-11287.02.patch Thanks for the review [~eddyxu]. Sure, and I would also make it a final variable to avoid redefinition in other places. Attached v02 patch incorporating this comment. Kindly take a look. > Storage class member storageDirs should be private to avoid unprotected > access by derived classes > ------------------------------------------------------------------------------------------------- > > Key: HDFS-11287 > URL: https://issues.apache.org/jira/browse/HDFS-11287 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 3.0.0-alpha1 > Reporter: Manoj Govindassamy > Assignee: Manoj Govindassamy > Attachments: HDFS-11287.01.patch, HDFS-11287.02.patch > > > HDFS-11267 fix made the abstract class Storage.java member variable > storageDirs a thread safe one so that all its derived classes like NNStorage, > JNStorage, DataStorage will not face any ConcurrentModificationException when > there are volume add/remove and listing operations running in parallel. The > fix rebase missed out few changers to the original patch. This jira is to > address the addendum needed for the HDFS-11267 commits. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org