[
https://issues.apache.org/jira/browse/HDFS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029611#comment-13029611
]
Eli Collins commented on HDFS-1799:
-----------------------------------
Will StorageDirectory ever be removed from JournalManager's interface? It seems
like an implementation detail of FileJournalManager. We should punt this to a
later change (eg HDFS-1580) but, as is, JournalManager is overly abstract if it
doesn't hide storage directories.
I agree with Ivan that the coupling of the journal and stream isn't obvious. In
an ideal the coupling would be introduced as part of the change that
necessitates it. I know it's hard to fold the right refactorings into the right
patches so let's go with it for now and revisit if necessary when the coupling
is used.
The latest patch looks good, minor comments:
* Agree that JournalManager open and createDivertedStream should be consistent,
eg both either open or create, doesn't matter much since both are going away.
* ELOS#abort needs a javadoc
* s/sizeOutputFlushBuffer/outputFlushBufferSize/
* Lots of newlines after the JournalAndStream constructor
> Refactor log rolling and filename management out of FSEditLog
> -------------------------------------------------------------
>
> Key: HDFS-1799
> URL: https://issues.apache.org/jira/browse/HDFS-1799
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: Edit log branch (HDFS-1073)
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: Edit log branch (HDFS-1073)
>
> Attachments: 0001-Added-state-management-to-FSEditLog.patch,
> 0002-Standardised-error-pattern.patch,
> 0003-Add-JournalFactory-and-move-divert-revert-out-of-FSE.patch,
> HDFS-1799-all.diff, hdfs-1799-alternate-design.txt, hdfs-1799.txt,
> hdfs-1799.txt, hdfs-1799.txt, hdfs-1799.txt
>
>
> This is somewhat similar to HDFS-1580, but less ambitious. While that JIRA
> focuses on pluggability, this task is simply the minimum needed for HDFS-1073:
> - Refactor the filename-specific code for rolling, diverting, and reverting
> log streams out of FSEditLog into a new class
> - Clean up the related code in FSEditLog a bit
> Notably, this JIRA is going to temporarily break the BackupNode. I plan to
> circle back on the BackupNode later on this branch.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
