[
https://issues.apache.org/jira/browse/HDFS-11340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831362#comment-15831362
]
Lei (Eddy) Xu edited comment on HDFS-11340 at 1/20/17 8:06 AM:
---------------------------------------------------------------
Thanks for reporting this, [~manojg]
{code}
if (!volumeFailureInfos.containsKey(volumeFailureInfo
.getFailedStorageLocation())) {
volumeFailureInfos.put(volumeFailureInfo.getFailedStorageLocation(),
volumeFailureInfo);
}
{code}
I dont feel that we need to check the existence of key first, would you
elaborate what case this change try to fix?
{code}
public VolumeFailureInfo[] getVolumeFailureInfos()
{code}
We dont need to change it to {{public}}.
Overall it LGTM. But it'd be nice if we can get comments from [~cnauroth].
was (Author: eddyxu):
Thanks for reporting this, [~manojg]
{code}
if (!volumeFailureInfos.containsKey(volumeFailureInfo
.getFailedStorageLocation())) {
volumeFailureInfos.put(volumeFailureInfo.getFailedStorageLocation(),
volumeFailureInfo);
}
{code}
I dont feel that we need to check the existence of key first, would you
elaborate what case this change try to fix?
{code}
public VolumeFailureInfo[] getVolumeFailureInfos()
{code}
We dont need to change it to {{public}}.
> DataNode reconfigure for disks doesn't remove the failed volumes
> ----------------------------------------------------------------
>
> Key: HDFS-11340
> URL: https://issues.apache.org/jira/browse/HDFS-11340
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha1
> Reporter: Manoj Govindassamy
> Assignee: Manoj Govindassamy
> Attachments: HDFS-11340.01.patch
>
>
> Say a DataNode (uuid:xyz) has disks D1 and D2. When D1 turns bad, JMX query
> on FSDatasetState-xyz for "NumFailedVolumes" attr rightly shows the failed
> volume count as 1 and the "FailedStorageLocations" attr has the failed
> storage location as "D1".
> It is possible to add or remove disks to this DataNode by running
> {{reconfigure}} command. Let the failed disk D1 be removed from the conf and
> the new conf has only one good disk D2. Upon running the reconfigure command
> for this DataNode with this new disk conf, the expectation is DataNode would
> no more have "NumFailedVolumes" or "FailedStorageLocations". But, even after
> removing the failed disk from the conf and a successful reconfigure, DataNode
> continues to show the "NumFailedVolumes" as 1 and "FailedStorageLocations" as
> "D1" and it never gets reset.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
