[
https://issues.apache.org/jira/browse/HDFS-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862115#comment-15862115
]
Xiao Chen commented on HDFS-6301:
---------------------------------
Hi, sorry for pinging on this 3yo jira...
[~andrew.wang] recently had a comment on HDFS-10899, which I traced back to
this jira.
{quote}
Looks like we aren't using the op cache in FSEditLog SetXAttrOp /
RemoveXAttrOp. I think this is accidental, could you do some research?
Particularly since we'll be doing a lot of SetXAttrOps, avoiding all that
object allocation would be nice. This could be a separate JIRA.
{quote}
Checking on latest trunk, only {{SetXAttrOp}}, {{RemoveXAttrOp}} and
{{SetAclOp}} doesn't use the cache. I can't think of why a cache can't be used
in this case, and would be happy to fix this in a new jira if this is a bug.
Could you please confirm?
i.e.
{code}
static SetXAttrOp getInstance() {
return new SetXAttrOp();
}
{code}
v.s.
{code}
static AddOp getInstance(OpInstanceCache cache) {
return (AddOp) cache.get(OP_ADD);
}
{code}
Thanks.
> NameNode: persist XAttrs in fsimage and record XAttrs modifications to edit
> log.
> --------------------------------------------------------------------------------
>
> Key: HDFS-6301
> URL: https://issues.apache.org/jira/browse/HDFS-6301
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Fix For: HDFS XAttrs (HDFS-2006)
>
> Attachments: HDFS-6301.1.patch, HDFS-6301.patch
>
>
> Store XAttrs in fsimage so that XAttrs are retained across NameNode restarts.
> Implement a new edit log opcode, {{OP_SET_XATTRS}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
