[ https://issues.apache.org/jira/browse/HDFS-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030907#comment-13030907 ]
Suresh Srinivas commented on HDFS-1865: --------------------------------------- Minor comments: # I prefer to retain using "DFSClient" instead of simple class name while building the client name. # TestLease could be simplified using mockito # Javadoc could be more descriptive for LeaseRenewer > Share LeaseChecker thread among DFSClients > ------------------------------------------ > > Key: HDFS-1865 > URL: https://issues.apache.org/jira/browse/HDFS-1865 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs client > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Attachments: h1865_20110503.patch, h1865_20110504.patch, > h1865_20110508.patch, h1865_20110508b.patch > > > Each {{DFSClient}} runs a {{LeaseChecker}} thread within a JVM. The number > threads could be reduced by sharing the threads. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira