[
https://issues.apache.org/jira/browse/HDFS-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879154#comment-15879154
]
Xiaoyu Yao commented on HDFS-11184:
-----------------------------------
Thanks [~anu] for working on this. The patch v005 looks pretty good to me.
Here are my comments on a few minor issues.
*StorageContainerManager.java*
Line 95: NIT: "HDFS" can be removed
Line 100: May need to update with the new SCM protocol.
Line 103: @InterfaceAudience.Private should we use the LimitedPrivate here as it
will likely for both HDFS and HBase
Line 122,123: NIT: suggest rename scmRpcServer -> clientRpcServer
scmRpcAddress->clientRpcAddress
Line 139: Do we have a ticket for fixing the SCM ClusterID generation?
Line 159: should we move the log message to StorageContainerManager#start()
where
the rpc server actually started?
Line 176 :same as above.
Line 186/206/235/272/288: remove static
Line 190: the string concat for host and port is not necessary? Can we
use addr and its toString() implicitly
Line 241: should we update the host part when updateListenAddress() if the host
is allowed to be configured as 0.0.0.0?
Line 298: let's open a separate ticket for SCM HA support if there isn't one
yet.
Line 357: can we add a log message for the rpc server stop?
*ContainerMapping.java*
Line 91: NIT: typo contianer -> container
Line 88: javadoc does not match the actual code, but we can fix that later.
*ContainerProtocolCalls.java*
Line 230: javadoc should be the client that perform the call
*MiniOzoneCluster.java*
Line 340: can we open a ticket to fix the datanode id issue in the TODO?
*TestAllocateContainer.java*
Line 57: if (cluster != null)
> Ozone: SCM: Make SCM use container protocol
> -------------------------------------------
>
> Key: HDFS-11184
> URL: https://issues.apache.org/jira/browse/HDFS-11184
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-11184-HDFS-7240.001.patch,
> HDFS-11184-HDFS-7240.002.patch, HDFS-11184-HDFS-7240.003.patch,
> HDFS-11184-HDFS-7240.004.patch, HDFS-11184-HDFS-7240.005.patch
>
>
> SCM will start using container protocol to communicate with datanodes.
> This change introduces some test failures due to some missing features which
> will be moved to KSM. Will file separate JIRA to track disabled ozone tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
