[ https://issues.apache.org/jira/browse/HDFS-11426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879176#comment-15879176 ]
Wei-Chiu Chuang commented on HDFS-11426: ---------------------------------------- Hi Andrew, thanks much for addressing my review in the new patch. One more nitpick: {code} ErasureCodingPolicy ecPolicy = dfs.getErasureCodingPolicy(p); if (ecPolicy != null) { System.out.println(ecPolicy.getName()); } else { System.out.println("The erasure coding policy of " + path + " is " + "unspecified"); } {code} Looking at {{FSDirErasureCodingOp#getErasureCodingPolicyForPath}}, the ecPolicy can be null due to: # the file is not striped # the policy id associated with the file is unsupported # symlink directory (current implementation do not support ecpolicy for symlink dir) # the directory, not its parents does not have a ec policy specified. It's a little vague saying the ec policy is unspecified considering it can be any of the 4 cases. > Refactor EC CLI to be similar to storage policies CLI > ----------------------------------------------------- > > Key: HDFS-11426 > URL: https://issues.apache.org/jira/browse/HDFS-11426 > Project: Hadoop HDFS > Issue Type: Improvement > Components: erasure-coding, shell > Affects Versions: 3.0.0-alpha1 > Reporter: Andrew Wang > Assignee: Andrew Wang > Labels: hdfs-ec-3.0-must-do > Attachments: HDFS-11426.001.patch, HDFS-11426.002.patch, > HDFS-11426.003.patch > > > The {{hdfs erasurecode}} CLI is similar to {{hdfs storagepolicies}} in terms > of functionality, but different in terms of behavior. Let's refactor > {{ECCli}} to be more similar to the various Admin classes we already have, > and also make its calling syntax mimic {{hdfs storagepolicies}} as closely as > possible. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org