[ 
https://issues.apache.org/jira/browse/HDFS-11432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887976#comment-15887976
 ] 

Vinayakumar B commented on HDFS-11432:
--------------------------------------

Looks almost Good.
Just two nits.
1. {{testSnapshotCommandsWithURI()}}, add timeout ~60sec.
2. better to explain in comments why you using fresh config with different URI 
in below code.
{code}  Configuration config = new HdfsConfiguration();
       config.set("fs.defaultFS", "hdfs://127.0.0.1:1024");
       String path = fs.getUri() + "/Fully/QPath";{code}

+1 once addressed.

> Federation : Support fully qualified path for 
> Quota/Snapshot/cacheadmin/cryptoadmin commands
> --------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11432
>                 URL: https://issues.apache.org/jira/browse/HDFS-11432
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: federation
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HDFS-11432-002.patch, HDFS-11432-003.patch, 
> HDFS-11432.patch
>
>
> As of now, client needs to change "fs.defaultFS" to connect to specific name 
> service when cluster is federated cluster which will be inconvenient for user.
>  *Snapshot* 
> {noformat}
>  hdfs dfsadmin -allowSnapshot hdfs://hacluster/Dir1/snapdir2
> allowSnapshot: FileSystem viewfs://ClusterX/ is not an HDFS file system
> Usage: hdfs dfsadmin [-allowSnapshot <snapshotDir>]
> {noformat}
>  *Quota* 
> {noformat}
> hdfs dfsadmin -setQuota 10 hdfs://hacluster/Bulkload
> setQuota: FileSystem viewfs://ClusterX/ is not an HDFS file system
> Usage: hdfs dfsadmin [-setQuota <quota> <dirname>...<dirname>]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to