[ https://issues.apache.org/jira/browse/HDFS-11499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897881#comment-15897881 ]
Inigo Goiri commented on HDFS-11499: ------------------------------------ The fix seems correct to me and the unit test seems good enough. I think the other uses of {{hasMinStorage()}} are correct. It seems this was introduced in HDFS-1172 a couple years ago; [~tlipcon], [~iwasakims], do you mind taking a look? > Decommissioning stuck because of failing recovery > ------------------------------------------------- > > Key: HDFS-11499 > URL: https://issues.apache.org/jira/browse/HDFS-11499 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs, namenode > Affects Versions: 2.7.1, 2.7.2, 2.7.3, 3.0.0-alpha2 > Reporter: Lukas Majercak > Assignee: Lukas Majercak > Labels: blockmanagement, decommission, recovery > Fix For: 3.0.0-alpha3 > > Attachments: HDFS-11499.patch > > > Block recovery will fail to finalize the file if the locations of the last, > incomplete block are being decommissioned. Vice versa, the decommissioning > will be stuck, waiting for the last block to be completed. > {code:xml} > org.apache.hadoop.ipc.RemoteException(java.lang.IllegalStateException): > Failed to finalize INodeFile testRecoveryFile since blocks[255] is > non-complete, where blocks=[blk_1073741825_1001, blk_1073741826_1002... > {code} > The fix is to count replicas on decommissioning nodes when completing last > block in BlockManager.commitOrCompleteLastBlock, as we know that the > DecommissionManager will not decommission a node that has UC blocks. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org