[ https://issues.apache.org/jira/browse/HDFS-11496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898035#comment-15898035 ]
Anu Engineer commented on HDFS-11496: ------------------------------------- [~busbey] Thanks for your comment. I agree that changing invariants is a bad idea. That is why I filed this JIRA to get your expert comments. I will try to fix it the way you are suggesting. Before I do that, I wanted to ask you why this is not happening in trunk and why this change is needed in Ozone branch, any guesses to where the root issue might be ? > Ozone: Merge with trunk needed a ignore duplicate entry in pom file due to > shading > ---------------------------------------------------------------------------------- > > Key: HDFS-11496 > URL: https://issues.apache.org/jira/browse/HDFS-11496 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Anu Engineer > > The trunk merge needed a hack in the > hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml to ignore > netty files. Not sure that is the right thing to do, so tracking here if we > need to revert this change before we merge. > {code} > ~/a/hadoop> git diff > hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml > ───────────────────────────────────────────────── > modified: hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml > ───────────────────────────────────────────────── > @ pom.xml:106 @ > <ignoreClass>*</ignoreClass> > </ignoreClasses> > </dependency> > <dependency> > <!--Duplicate classes found:--> > <!--Found in:--> > > <!--org.apache.hadoop:hadoop-client-runtime:jar:3.0.0-alpha3-SNAPSHOT:compile--> > > <!--org.apache.hadoop:hadoop-client-minicluster:jar:3.0.0-alpha3-SNAPSHOT:compile--> > <ignoreClasses> > <groupId>io.netty</groupId> > <artifactId>netty</artifactId> > <ignoreClass>*</ignoreClass> > </ignoreClasses> > </dependency> > </dependencies> > </banDuplicateClasses> > </rules> > {code} > [~andrew.wang] or [~busbey] Would one of you care to comment if this is the > right thing to do ? Thanks in advance. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org