[ https://issues.apache.org/jira/browse/HDFS-11163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898092#comment-15898092 ]
Chris Nauroth commented on HDFS-11163: -------------------------------------- The {{FsServerDefaults}} class is annotated {{Public}}, so let's maintain the existing constructor signature and add a new constructor that supports passing default storage policy ID. The old constructor can delegate to the new constructor with default storage policy ID of 0. That also would remove the need to change {{FtpConfigKeys}} and {{LocalConfigKeys}} in this patch. The logic is looking good to me, but I'd still like a second opinion review before committing anything. > Mover should move the file blocks to default storage once policy is unset > ------------------------------------------------------------------------- > > Key: HDFS-11163 > URL: https://issues.apache.org/jira/browse/HDFS-11163 > Project: Hadoop HDFS > Issue Type: Bug > Components: balancer & mover > Affects Versions: 2.8.0 > Reporter: Surendra Singh Lilhore > Assignee: Surendra Singh Lilhore > Attachments: HDFS-11163-001.patch, HDFS-11163-002.patch, > HDFS-11163-003.patch, HDFS-11163-004.patch, HDFS-11163-005.patch, > temp-YARN-6278.HDFS-11163.patch > > > HDFS-9534 added new API in FileSystem to unset the storage policy. Once > policy is unset blocks should move back to the default storage policy. > Currently mover is not moving file blocks which have zero storage ID > {code} > // currently we ignore files with unspecified storage policy > if (policyId == HdfsConstants.BLOCK_STORAGE_POLICY_ID_UNSPECIFIED) { > return; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org