[
https://issues.apache.org/jira/browse/HDFS-11511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925319#comment-15925319
]
Arpit Agarwal edited comment on HDFS-11511 at 3/15/17 12:19 AM:
----------------------------------------------------------------
Thanks [~hanishakoneru]! The changes look good. A few more comments:
# ThrottledAsyncChecker#shutdownAndWait should also shutdown
scheduledExecutorService if it is non-null (sorry I missed this one earlier).
# You don't need the additional _"Licensed to the Apache Software Foundation
(ASF) ..." header in AbstractFuture.java and TimeoutFuture.java.
# In TestThrottledAsyncCheckerTimeout#testDiskCheckTimeout, you can use a
[ReentrantLock|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/ReentrantLock.html].
# We should assert that {{olf.isPresent is true}} everywhere instead of the
{{if (olf.isPresent())}} check.
# Move the mutex/lock initialization to a @Before method, so it is reallocated
for each test case.
# DummyCheckable#check should release the mutex/lock immediately after getting
it.
To suppress the findbugs issues in the Guava classes, we should add
AbstractFuture and TimeoutFuture to
[findbugsExclude.xml|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml].
was (Author: arpitagarwal):
Thanks [~hanishakoneru]! The changes look good. A few more comments:
# ThrottledAsyncChecker#shutdownAndWait should also shutdown
scheduledExecutorService if it is non-null.
# You don't need the additional _"Licensed to the Apache Software Foundation
(ASF) ..." header in AbstractFuture.java and TimeoutFuture.java.
# In TestThrottledAsyncCheckerTimeout#testDiskCheckTimeout, you can use a
[ReentrantLock|https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/ReentrantLock.html].
# We should assert that {{olf.isPresent is true}} everywhere instead of the
{{if (olf.isPresent())}} check.
# Move the mutex/lock initialization to a @Before method, so it is reallocated
for each test case.
# DummyCheckable#check should release the mutex/lock immediately after getting
it.
To suppress the findbugs issues in the Guava classes, we should add
AbstractFuture and TimeoutFuture to
[findbugsExclude.xml|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml].
> Support Timeout when checking single disk
> -----------------------------------------
>
> Key: HDFS-11511
> URL: https://issues.apache.org/jira/browse/HDFS-11511
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Attachments: HDFS-11511.000.patch, HDFS-11511.001.patch,
> HDFS-11511.002.patch
>
>
> HDFS-11149 introduces parallel checking of FsVolumes by Datanode. Disk checks
> should have a configurable timeout so that bad disks do not hang and cause
> long running checks.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
