[
https://issues.apache.org/jira/browse/HDFS-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928886#comment-15928886
]
Virajith Jalaparti commented on HDFS-6708:
------------------------------------------
Thanks for the quick response [~ehiggs].
One minor comment: could you please swap the names of the parameters
({{allowed}}, and {{requested}}) in
{{TestBlockStoragePolicy#testStorageTypeCheckAccessResult}}, to be consistent
with the names in {{BlockTokenSecretManager#checkAccess}}? It is a bit
confusing.
Other than that, lgtm +1
> StorageType should be encoded in the block token
> ------------------------------------------------
>
> Key: HDFS-6708
> URL: https://issues.apache.org/jira/browse/HDFS-6708
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Affects Versions: 2.4.1
> Reporter: Arpit Agarwal
> Assignee: Ewan Higgs
> Fix For: 3.0.0-alpha3
>
> Attachments: HDFS-6708.0001.patch, HDFS-6708.0002.patch,
> HDFS-6708.0003.patch, HDFS-6708.0004.patch, HDFS-6708.0005.patch
>
>
> HDFS-6702 is adding support for file creation based on StorageType.
> The block token is used as a tamper-proof channel for communicating block
> parameters from the NN to the DN during block creation. The StorageType
> should be included in this block token.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
