[ https://issues.apache.org/jira/browse/HDFS-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032607#comment-13032607 ]
Matt Foley commented on HDFS-1505: ---------------------------------- One more related issue: at the end of saveNamespace() it calls "editLog.open()", which is implemented by FSEditLog.open(). This routine has the same problem: if the list of EditLogOutputStream is empty, it appears to succeed, but should throw an exception. I would suggest fixing the lack of notification in FSEditLog.open(), but also in your patch to saveNamespace() the check for empty IMAGE and EDITS lists should precede the call to editLog.open(). > saveNamespace appears to succeed even if all directories fail to save > --------------------------------------------------------------------- > > Key: HDFS-1505 > URL: https://issues.apache.org/jira/browse/HDFS-1505 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 0.22.0, 0.23.0 > Reporter: Todd Lipcon > Assignee: Aaron T. Myers > Priority: Blocker > Fix For: 0.22.0 > > Attachments: hdfs-1505-22.0.patch, hdfs-1505-22.1.patch, > hdfs-1505-test.txt, hdfs-1505-trunk.0.patch, hdfs-1505-trunk.1.patch > > > After HDFS-1071, saveNamespace now appears to "succeed" even if all of the > individual directories failed to save. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira