[ https://issues.apache.org/jira/browse/HDFS-11564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954006#comment-15954006 ]
Xiaoyu Yao commented on HDFS-11564: ----------------------------------- Thanks [~anu] for the update. +1 for the latest patch.The minor checkstyle issue can be fixed at commit time. {code} ./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/container/placement/TestDatanodeMetrics.java:27:import static org.junit.Assert.assertFalse;:15: Unused import - org.junit.Assert.assertFalse. [UnusedImports] {code} > Ozone: SCM: Add Comparable Metric Support > ----------------------------------------- > > Key: HDFS-11564 > URL: https://issues.apache.org/jira/browse/HDFS-11564 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone > Affects Versions: HDFS-7240 > Reporter: Anu Engineer > Assignee: Anu Engineer > Attachments: HDFS-11564-HDFS-7240.001.patch, > HDFS-11564-HDFS-7240.002.patch, HDFS-11564-HDFS-7240.003.patch, > HDFS-11564-HDFS-7240.004.patch > > > While picking the datanode or the pool to place a container, SCM needs to be > able to compare pools and datanodes. This jira proposes to add a Comparable > Metric interface from which DatanodeCapacity and DatanodeIOLoad metrics can > be derived. This will also convert SCM Container Placement Capacity policy to > use these metrics. > Adding these metrics makes all placement policy operate on the basis of these > metrics and it makes it easy to simulate cluster imbalances as well as reason > about code. All new SCM metrics which have the property of total ordering > should be derived from this interface. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org