[ 
https://issues.apache.org/jira/browse/HDFS-11362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959879#comment-15959879
 ] 

Hanisha Koneru commented on HDFS-11362:
---------------------------------------

Thank you [~xyao] for committing the patch.

> StorageDirectory should initialize a non-null default StorageDirType
> --------------------------------------------------------------------
>
>                 Key: HDFS-11362
>                 URL: https://issues.apache.org/jira/browse/HDFS-11362
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Minor
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: HDFS-11362.000.patch, HDFS-11362.001.patch
>
>
> _Storage#shouldReturnNextDir_ method checks if the next Storage directory is 
> of the same type us dirType.
> {noformat}
>     private boolean shouldReturnNextDir() {
>       StorageDirectory sd = getStorageDir(nextIndex);
>       return (dirType == null || sd.getStorageDirType().isOfType(dirType)) &&
>           (includeShared || !sd.isShared());
>     }
> {noformat}
> There is a possibility that sd.getStorageDirType() returns null (default 
> dirType is null). Hence, before checking for type match, we should make sure 
> that the value returned by sd.getStorageDirType() is not null.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to