[ https://issues.apache.org/jira/browse/HDFS-11634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966286#comment-15966286 ]
Rushabh S Shah commented on HDFS-11634: --------------------------------------- bq. Hope this makes sense. Makes perfect sense. +1 (non-binding). There are couple of checkstyle warnings carried over from patch#2. I wouldn't worry about submitting a new patch and wasting build resources. The committer can fix it while committing. [~shv]: thanks for the fix. Hopefully some committer can review and commit. :) > Optimize BlockIterator when interating starts in the middle. > ------------------------------------------------------------ > > Key: HDFS-11634 > URL: https://issues.apache.org/jira/browse/HDFS-11634 > Project: Hadoop HDFS > Issue Type: Improvement > Affects Versions: 2.6.5 > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Attachments: HDFS-11634.001.patch, HDFS-11634.002.patch, > HDFS-11634.003.patch > > > {{BlockManager.getBlocksWithLocations()}} needs to iterate blocks from a > randomly selected {{startBlock}} index. It creates an iterator which points > to the first block and then skips all blocks until {{startBlock}}. It is > inefficient when DN has multiple storages. Instead of skipping blocks one by > one we can skip entire storages. Should be more efficient on average. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org