[
https://issues.apache.org/jira/browse/HDFS-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032882#comment-13032882
]
Hadoop QA commented on HDFS-1921:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479025/hdfs1921_v23.patch
against trunk revision 1102513.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestHDFSCLI
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.tools.TestJMXGet
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/512//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/512//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/512//console
This message is automatically generated.
> Save namespace can cause NN to be unable to come up on restart
> --------------------------------------------------------------
>
> Key: HDFS-1921
> URL: https://issues.apache.org/jira/browse/HDFS-1921
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.22.0, 0.23.0
> Reporter: Aaron T. Myers
> Assignee: Matt Foley
> Priority: Blocker
> Fix For: 0.22.0, 0.23.0
>
> Attachments: hdfs-1505-1-test.txt, hdfs1921_v23.patch,
> hdfs1921_v23.patch
>
>
> I discovered this in the course of trying to implement a fix for HDFS-1505.
> Per the comment for {{FSImage.saveNamespace(...)}}, the algorithm for save
> namespace proceeds in the following order:
> # rename current to lastcheckpoint.tmp for all of them,
> # save image and recreate edits for all of them,
> # rename lastcheckpoint.tmp to previous.checkpoint.
> The problem is that step 3 occurs regardless of whether or not an error
> occurs for all storage directories in step 2. Upon restart, the NN will see
> non-existent or corrupt {{current}} directories, and no
> {{lastcheckpoint.tmp}} directories, and so will conclude that the storage
> directories are not formatted.
> This issue appears to be present on both 0.22 and 0.23. This should arguably
> be a 0.22/0.23 blocker.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
