[ 
https://issues.apache.org/jira/browse/HDFS-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981281#comment-15981281
 ] 

Weiwei Yang commented on HDFS-11691:
------------------------------------

Hi [~kihwal]

Thanks for catching and fixing this. I have one small comment here

{code}
+    <td ng-value="{state}-{name}"><a 
href='{dnWebAddress}'>{dnWebAddress}</a></td>
{code}

this way datanode link field on UI will also display 
{{http://datanodehost:port}} instead of {{datanodehost:port}}, this look&feel 
change will be OK right?

> Add a proper scheme to the datanode links in NN web UI
> ------------------------------------------------------
>
>                 Key: HDFS-11691
>                 URL: https://issues.apache.org/jira/browse/HDFS-11691
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>         Attachments: HDFS-11691.patch
>
>
> On the datanodes page of the namenode web UI, the datanode links may not be 
> correct if the namenode is serving the page through http but https is also 
> enabled.  This is because {{dfshealth.js}} does not put a proper scheme in 
> front of the address.  It already determines whether the address is 
> non-secure or secure. It can simply prepend {{http:}} or {{https:}} to what 
> it is currently setting.
> The existing mechanism would work for YARN and MAPRED, since they can only 
> serve one protocol, HTTP or HTTPS.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to