[ 
https://issues.apache.org/jira/browse/HDFS-11675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989118#comment-15989118
 ] 

Xiaoyu Yao commented on HDFS-11675:
-----------------------------------

Looks good to me. +1. I only have a minor question.

DeleteContainerHandler.java Line 59
Do we output the deleting/deleted info in the console window as the CLI output? 
Not sure if we always set the console option for the log4j settings of the CLI. 

{code}
59          LOG.info("Deleting container : {}", containerName);
60          getScmClient().deleteContainer(pipeline, cmd.hasOption(OPT_FORCE));
61          LOG.info("Container {} deleted", containerName);
{code}

> Ozone: SCM CLI: Implement delete container command
> --------------------------------------------------
>
>                 Key: HDFS-11675
>                 URL: https://issues.apache.org/jira/browse/HDFS-11675
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>              Labels: command-line
>         Attachments: HDFS-11675-HDFS-7240.001.patch, 
> HDFS-11675-HDFS-7240.002.patch, HDFS-11675-HDFS-7240.003.patch, 
> HDFS-11675-HDFS-7240.004.patch
>
>
> Implement delete container
> {code}
> hdfs scm -container del <container name> -f
> {code}
> Deletes a container if it is empty. The -f options can be used to force a 
> delete of a non-empty container. If container name specified not exist, 
> prints a clear error message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to