[ https://issues.apache.org/jira/browse/HDFS-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Badger updated HDFS-10459: ------------------------------- Resolution: Won't Fix Status: Resolved (was: Patch Available) Not a critical fix for 2.7, so closing as won't fix. As for trunk, after speaking offline with [~daryn] and [~kihwal], it looks like truncating (i.e. rounding down) is the easier approach here, so we'll just leave this as is and not change anything. The off by 1 error is already fixed there. > getTurnOffTip computes needed block incorrectly for threshold < 1 in b2.7 > ------------------------------------------------------------------------- > > Key: HDFS-10459 > URL: https://issues.apache.org/jira/browse/HDFS-10459 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Eric Badger > Assignee: Eric Badger > Attachments: HDFS-10459.001.patch, HDFS-10459.002.patch, > HDFS-10459.003.patch, HDFS-10459-b2.7.002.patch, HDFS-10459-b2.7.003.patch > > > GetTurnOffTip overstates the number of blocks necessary to come out of safe > mode by 1 due to an arbitrary '+1' in the code. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org