[ https://issues.apache.org/jira/browse/HDFS-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989738#comment-15989738 ]
John Zhuge commented on HDFS-11710: ----------------------------------- +1 LGTM. [~vinayrpet] and [~Sammi], could you please build the patch on Windows and possibly run the unit tests? I don't have access to a Windows env quickly. > hadoop-hdfs-native-client build fails in trunk after HDFS-11529 > --------------------------------------------------------------- > > Key: HDFS-11710 > URL: https://issues.apache.org/jira/browse/HDFS-11710 > Project: Hadoop HDFS > Issue Type: Bug > Components: native > Affects Versions: 3.0.0-alpha3 > Reporter: Vinayakumar B > Assignee: Sailesh Mukil > Priority: Blocker > Attachments: HDFS-11710.000.patch > > > HDFS-11529 used 'hdfsThreadDestructor()' in jni_helper.c. > But this function is implemented in only "posix/thread_local_storage.c" NOT > in > "windows/thread_local_storage.c" > Fails with following errors > {noformat} > [exec] hdfs.dir\RelWithDebInfo\thread_local_storage.obj /machine:x64 > /debug > [exec] Creating library > D:/hadoop/work/hadoop-hdfs-project/hadoop-hdfs-native-client/target/native/bin/RelWithDebInfo/hdfs.lib > and object > D:/hadoop/work/hadoop-hdfs-project/hadoop-hdfs-native-client/target/native/bin/RelWithDebInfo/hdfs.exp > [exec] jni_helper.obj : error LNK2019: unresolved external symbol > hdfsThreadDestructor referenced in function getJNIEnv > [D:\hadoop\work\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfs\hdfs.vcxproj] > [exec] > D:\hadoop\work\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\bin\RelWithDebInfo\hdfs.dll > : fatal error LNK1120: 1 unresolved externals > [D:\hadoop\work\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfs\hdfs.vcxproj] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org