[ 
https://issues.apache.org/jira/browse/HDFS-11717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991981#comment-15991981
 ] 

Konstantin Shvachko commented on HDFS-11717:
--------------------------------------------

Well if it is an error, then throwing exception would have been fine. But you 
want it to continue, which makes the log message a warning, imho.
Anyways I am fine either way as long as the two warning message in 
{{StandbyCheckpointer}} and {{SecondaryNameNode}} related to the same condition 
are at least at the same logging level. Exactly the same would be ideal.

> Add unit test for HDFS-11709 StandbyCheckpointer should handle non-existing 
> legacyOivImageDir gracefully
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-11717
>                 URL: https://issues.apache.org/jira/browse/HDFS-11717
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: ha, namenode
>    Affects Versions: 2.9.0, 2.7.4, 3.0.0-alpha3, 2.8.1
>            Reporter: Erik Krogen
>            Assignee: Erik Krogen
>            Priority: Minor
>         Attachments: HDFS-11717.000.patch
>
>
> As a follow on to HDFS-11709 which made the StandbyCheckpointer more 
> gracefully handle the situation that a legacy OIV image dir is misconfigured, 
> write a unit test for it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to