[
https://issues.apache.org/jira/browse/HDFS-11644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manoj Govindassamy updated HDFS-11644:
--------------------------------------
Attachment: HDFS-11644.03.patch
Thanks [~ste...@apache.org], [~andrew.wang] for the review. Attached v03 patch
with following comments addressed. please take a look.
1. (StreamCapability) I don't want an enum though, I'd like a string.
Done. I had it as an enum so that client applications can get to easily see
list of available capabilities and also for easy documentation purposes. But,
string based capability checking model also has good benefits like you
detailed. I combined the enum and string approach to get the best of both. Let
me please know if you think otherwise.
2. your tests don't need to catch raised exceptions, just throw them up and let
JUnit deal with it.
Done.
3. Does this need to check Syncable?
Should not be needed. Removed.
4, helper method that takes a stream-specific string->boolean map, or something
like that
As of now only one output stream supports Syncable capabilities. Will add some
helper routine once more streams start supporting various capabilties.
> DFSStripedOutputStream should not implement Syncable
> ----------------------------------------------------
>
> Key: HDFS-11644
> URL: https://issues.apache.org/jira/browse/HDFS-11644
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: erasure-coding
> Affects Versions: 3.0.0-alpha1
> Reporter: Andrew Wang
> Assignee: Manoj Govindassamy
> Labels: hdfs-ec-3.0-must-do
> Attachments: HDFS-11644.01.patch, HDFS-11644.02.patch,
> HDFS-11644.03.patch
>
>
> FSDataOutputStream#hsync checks if a stream implements Syncable, and if so,
> calls hsync. Otherwise, it just calls flush. This is used, for instance, by
> YARN's FileSystemTimelineWriter.
> DFSStripedOutputStream extends DFSOutputStream, which implements Syncable.
> However, DFSStripedOS throws a runtime exception when the Syncable methods
> are called.
> We should refactor the inheritance structure so DFSStripedOS does not
> implement Syncable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
