[ 
https://issues.apache.org/jira/browse/HDFS-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999102#comment-15999102
 ] 

Xiaoyu Yao commented on HDFS-11693:
-----------------------------------

Thanks [~anu] for updating the patch. Patch v3 looks good to me. Just have two 
minor issues:

FileUtil.java
Line 610/640: should we close the CheckedOutputStream to avoid leak?
Line 685/707: should we close the CheckedInputStream to avoid leak?

TestArchive.java
The Jenkins failure seems related. Can you fix it?




> Ozone: Add archive support to containers
> ----------------------------------------
>
>                 Key: HDFS-11693
>                 URL: https://issues.apache.org/jira/browse/HDFS-11693
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>    Affects Versions: HDFS-7240
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>         Attachments: HDFS-11693-HDFS-7240.001.patch, 
> HDFS-11693-HDFS-7240.002.patch, HDFS-11693-HDFS-7240.003.patch
>
>
> Add archive support to containers. This is a stepping stone to supporting 
> copy containers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to