[
https://issues.apache.org/jira/browse/HDFS-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13034301#comment-13034301
]
Bharath Mundlapudi commented on HDFS-1905:
------------------------------------------
Thanks for the review, Suresh.
My comments:
1 & 3. From a high level, format returns boolean. Semantically, if this
operation was successful, we should return true else we should return false.
The previous code was bit not right. If format was successful, it was returning
false. Even if user opts to not format, format operation as such was not
successful, so we should return false. So, i changed this part also.
Let me know, if these assumptions are not correct, i will back to previous
semantics.
I will fix the doc and tests. Sorry, i missed this part.
Regarding upgrade, do you want me to do in another Jira? Since, this was just
filed for format usability.
> Improve the usability of namenode -format
> ------------------------------------------
>
> Key: HDFS-1905
> URL: https://issues.apache.org/jira/browse/HDFS-1905
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Bharath Mundlapudi
> Assignee: Bharath Mundlapudi
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: HDFS-1905-1.patch
>
>
> While setting up 0.23 version based cluster, i ran into this issue. When i
> issue a format namenode command, which got changed in 23, it should let the
> user know to how to use this command in case where complete options were not
> specified.
> ./hdfs namenode -format
> I get the following error msg, still its not clear what and how user should
> use this command.
> 11/05/09 15:36:25 ERROR namenode.NameNode:
> java.lang.IllegalArgumentException: Format must be provided with clusterid
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.format(NameNode.java:1483)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1623)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.main(NameNode.java:1689)
>
> The usability of this command can be improved.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
