[
https://issues.apache.org/jira/browse/HDFS-11768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005024#comment-16005024
]
Weiwei Yang commented on HDFS-11768:
------------------------------------
Hi [~anu]
Thanks for the work. Some comments below,
*KeyspaceManager.proto*
# Create volume API: I am a bit confused with {{adminName}} and {{ownerName}},
I thought a volume can be created by any valid user (not just ozone admin) and
the creator should be its owner. I don't understand the point to have an admin
and an owner.
# The response status from all volume operations seem to be similar, does it
make sense to reuse {{enum Status}} for all messages? And volume operations may
fail with I/O errors, does it make sense to add {{IO_ERROR}} to {{Status}}?
# {{VolumeInfo}} seems to need more fields, e.g data created, data modified,
size, volume status and volumeID. Or this might fit to a new message
{{VolumeStatus}} which can be used in {{InfoVolume}}.
# Delete volume API: why it is only allowed to delete a volume without any
bucket within? It seems pretty common for user to delete a volume owned by
themselves.
*ScmConfigKeys*
is it better to place ksm keys in a similar class such as {{KsmConfigKeys}} ?
*KeySpaceManager*
line 111 - java doc should be main entry for starting *KeySpaceManager*
> Ozone: KSM: Create Key Space manager service
> --------------------------------------------
>
> Key: HDFS-11768
> URL: https://issues.apache.org/jira/browse/HDFS-11768
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: HDFS-11768-HDFS-7240.001.patch, ozone-key-space.pdf
>
>
> KSM is the namespace manager for Ozone. KSM relies on SCM to achieve block
> functions. Ozone handler -- The rest protocol frontend talks to KSM and SCM
> to get datanode addresses.
> This JIRA will add the service as well as add the protobuf definitions needed
> to work with KSM.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
