[
https://issues.apache.org/jira/browse/HDFS-11811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007651#comment-16007651
]
Anu Engineer commented on HDFS-11811:
-------------------------------------
Patch looks quite good, Thanks for fixing this. Some very minor comments
1. what happens if I try to create a volume called "Deleted" Do you want to use
a character other than capital to indicate this is a system owned bucket ?
2. {{repeated string deletedKeys = 1;}} This tells us which key got deleted.
But gives us no information about why a key was not deleted. I do see that we
will log it in the SCM log. Would it make more sense to return a set of
<string, errorcode> like {{repeated deletedstatus deletedkeys = 1;}} So if you
are send a block that does not exist, you can return proper error.
3. There is a checkStyle warning.
> Ozone: SCM: Support Delete Block
> --------------------------------
>
> Key: HDFS-11811
> URL: https://issues.apache.org/jira/browse/HDFS-11811
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone, scm
> Affects Versions: HDFS-7240
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-11811-HDFS-7240.001.patch
>
>
> This is a follow up of HDFS-11504 to add delete block API. For each deleted
> block, we will remove the original entry for the block and add a tombstone in
> the blockstore db.
> We will add an async thread to process the tombstones and wait for the
> container report confirmation to eventually clean up the tombstones.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
