[
https://issues.apache.org/jira/browse/HDFS-11778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020818#comment-16020818
]
Mukul Kumar Singh commented on HDFS-11778:
------------------------------------------
Hi [~nandakumar131], Thanks for the patch. Please find my comments as follows
1) BuckerManagerImpl: 85, 129 please correct the comment,
rather I feel we should move this to MetadataManagerImpl.java where the key is
being constructed.
2) KeySpaceManager:366, please add a new metric, and update it here
3) KeySpaceManagerProtocol:114, variable name in comments are not correct
4) BucketManagerImpl:97 - the acls during creation should be fetched from the
KsmBucketInfo.
5) It would be great if we can add a test to TestKeySpaceManager, this will
help with end to end testing for all the APIs.
> Ozone: KSM: add getBucketInfo
> -----------------------------
>
> Key: HDFS-11778
> URL: https://issues.apache.org/jira/browse/HDFS-11778
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Nandakumar
> Attachments: HDFS-11778-HDFS-7240.000.patch
>
>
> Returns the bucket information if the bucket exists.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
