[
https://issues.apache.org/jira/browse/HDFS-11776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023780#comment-16023780
]
Chen Liang commented on HDFS-11776:
-----------------------------------
Thanks [~nandakumar131] for working on this! v000 patch LGTM, pending jenkins.
Some thoughts though, I was wondering, given {{setBucketProperty(KsmBucketArgs
args)}}, is it really useful at all to have the other set methods
{{setBucketVersioning(BucketArgs args)}}, {{void
setBucketStorageClass(BucketArgs args)}} and {{void setBucketAcls(BucketArgs
args)}}? Seems to me that setBucketProperty(KsmBucketArgs args) is the union of
the three. If we are to keep the three methods though, I think it is probably
better to change the signature, say, change {{setBucketStorageClass(BucketArgs
args)}} to {{setBucketStorageClass(String volumeName, String bucketName,
StorageType type)}} which makes it a wrapper exposed to client. Any thoughts?
Since this seems to come from older code, @[~anu].
> Ozone: KSM: add SetBucketProperty
> ---------------------------------
>
> Key: HDFS-11776
> URL: https://issues.apache.org/jira/browse/HDFS-11776
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Nandakumar
> Attachments: HDFS-11776-HDFS-7240.000.patch
>
>
> Allows changing the properties of an existing bucket. Properties supported by
> this call are
> # ACLs - Allows changing ACLs on a existing bucket.
> # StorageType - Allows users to control where the bucket should live. we
> ignore this for the time being, since SCM does not expose APIs for this yet.
> # Versioning - Enables versioning on buckets.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
