[
https://issues.apache.org/jira/browse/HDFS-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025498#comment-16025498
]
Xiaoyu Yao commented on HDFS-11780:
-----------------------------------
Thanks [~vagarychen] for the update. The patch v6 looks pretty good to me. A
few more comments below:
KeyManagerImpl.java
Line 75: I don't think we support key overwrite in ozone. We should throw
exception if key exists for now before supporting append/shrink, etc.
Line 88: NIT: the log message can be improved. e.g., LOG.debug("Key {}
allocated in volume {} bucket {}", keyName, volumeName, bucketName);
Line 92: same as above.
DistributedStorageHandler.java
Line 292-298: we need to handle some failure cases here: e.g.,
keySpaceManagerClient.allocateKey succeeded but
ContainerProtocolCalls.createContainer(xceiverClient, args.getRequestID())
failed.
BlockManagerImpl.java
Here we assumed that all the open containers have been created by client
successfully. This may not always be true as commented above. Client -> DN
container creation could fail. SCM can only get reliable confirmation based on
container report from SCM datanodes (which has not be fully implemented yet).
This need to be addressed when container report handling is fully implemented.
Please file a followup JIRA on this.
TestKeySpaceManager.java
Line 73: NIT: you may use the wrapper OzoneUtils#getRequestID here (same as
your current code).
> Ozone: KSM : Add putKey
> -----------------------
>
> Key: HDFS-11780
> URL: https://issues.apache.org/jira/browse/HDFS-11780
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Anu Engineer
> Assignee: Chen Liang
> Attachments: HDFS-11780-HDFS-7240.001.patch,
> HDFS-11780-HDFS-7240.002.patch, HDFS-11780-HDFS-7240.003.patch,
> HDFS-11780-HDFS-7240.004.patch, HDFS-11780-HDFS-7240.005.patch,
> HDFS-11780-HDFS-7240.006.patch, HDFS-11780-HDFS-7240.007.patch
>
>
> Support putting a key into an Ozone bucket.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
