[
https://issues.apache.org/jira/browse/HDFS-11771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033672#comment-16033672
]
Anu Engineer commented on HDFS-11771:
-------------------------------------
{code}
String userName;
if (acl.getName() == null) {
if (acl.getType() != OzoneAcl.OzoneACLType.WORLD) {
throw new IllegalArgumentException(
"Only world ACL Type can have null username");
}
userName = "world";
} else {
userName = acl.getName();
}
{code}
I still feel this is wrong, if I have a user called *world* then this will
conflict with that. I think the right fix is to remove this check and if the
user name is required due to protobuf then fix protobuf to make sure user name
optional.
> Ozone: KSM: Add checkVolumeAccess
> ----------------------------------
>
> Key: HDFS-11771
> URL: https://issues.apache.org/jira/browse/HDFS-11771
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Mukul Kumar Singh
> Attachments: HDFS-11771-HDFS-7240.001.patch,
> HDFS-11771-HDFS-7240.002.patch, HDFS-11771-HDFS-7240.003.patch,
> HDFS-11771-HDFS-7240.004.patch, HDFS-11771-HDFS-7240.005.patch,
> HDFS-11771-HDFS-7240.006.patch
>
>
> Checks if the caller has access to a given volume. This call supports the
> ACLs specified in the ozone rest protocol documentation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
